special case of datetime as not allowed in date serializer #873
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
When serializing
date | datetime
unions we do not want thedate
serializer to allowdatetime
inputs, as they are a lossy serialization.In general this seems undesirable, so I've gone for the approach of making
date
serializer disallowdatetime
always (and emit the usual unexpected type warning).Related issue number
Related to pydantic/pydantic#7039 (comment)
Checklist
pydantic-core
(except for expected changes)Selected Reviewer: @adriangb