-
Notifications
You must be signed in to change notification settings - Fork 247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support manually specifying case labels for union validators #841
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #841 +/- ##
==========================================
+ Coverage 93.85% 93.91% +0.06%
==========================================
Files 104 104
Lines 15387 15414 +27
Branches 25 25
==========================================
+ Hits 14441 14476 +35
+ Misses 940 932 -8
Partials 6 6
... and 6 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
CodSpeed Performance ReportMerging #841 will degrade performances by 24.34%Comparing Summary
Benchmarks breakdown
|
My only complaint is the performance hit. I wonder if a |
@adriangb what do you think now? That updated-to-40% threshold might be helping... 😈 But looking at the raw report it doesn't seem that obviously bad. Hard to tell I guess 🤷♂️. |
I will run a full local benchmark tomorrow and try to upload something useful. |
Had a quick chat with @samuelcolvin this morning and the impression I got was that he has opinions, I'm going to reassign this. |
please review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me 👍
- union schema choices type check added. Affected by pydantic/pydantic-core#841.
Produces error locs for union cases following the description in this comment: pydantic/pydantic#6897 (comment)
Also adds the ability to (optionally) specify the label to use for each union case.
I won't be offended if this gets rejected, or gets asked for some kind of rework.
Selected Reviewer: @davidhewitt