Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wasm preview #835

Merged
merged 5 commits into from
Jul 27, 2023
Merged

Fix wasm preview #835

merged 5 commits into from
Jul 27, 2023

Conversation

JeffersGlass
Copy link
Contributor

Change Summary

Fixes the WASM Preview by resolving a dependency mismatch in typing-extensions. Since pydantic-core version 2.0.0 it seems, the built wheel used in this demo already specifies typing-extensions as a dependency, and there's no need in install a (mismatched) version via loadPackage in advance.

Related issue number

Fixes #834.

Checklist

  • Documentation reflects the changes where applicable
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

@codecov
Copy link

codecov bot commented Jul 27, 2023

Codecov Report

Merging #835 (14b1233) into main (956f996) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #835   +/-   ##
=======================================
  Coverage   93.48%   93.48%           
=======================================
  Files         102      102           
  Lines       14606    14606           
  Branches       25       25           
=======================================
  Hits        13655    13655           
  Misses        945      945           
  Partials        6        6           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 956f996...14b1233. Read the comment docs.

@codspeed-hq
Copy link

codspeed-hq bot commented Jul 27, 2023

CodSpeed Performance Report

Merging #835 will improve performances by 10.56%

Comparing JeffersGlass:fix-wasm-preview (14b1233) with main (956f996)

Summary

🔥 2 improvements
✅ 133 untouched benchmarks

Benchmarks breakdown

Benchmark main JeffersGlass:fix-wasm-preview Change
🔥 test_small_class_core_model 50.3 µs 45.5 µs +10.56%
🔥 test_tagged_union_int_keys_json 48.7 µs 44.2 µs +10.03%

@dmontagu dmontagu merged commit d333dfa into pydantic:main Jul 27, 2023
@dmontagu
Copy link
Collaborator

I can confirm the WASM Preview is now working for me in chrome on MacOS. (And was not prior to merging this.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WASM Preview Fails with Dependency Mismatch
2 participants