-
Notifications
You must be signed in to change notification settings - Fork 247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use github continue-on-error to avoid red CI with test-pydantic-integration #817
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #817 +/- ##
=======================================
Coverage 93.50% 93.50%
=======================================
Files 102 102
Lines 14587 14587
Branches 25 25
=======================================
Hits 13639 13639
Misses 942 942
Partials 6 6 Continue to review full report in Codecov by Sentry.
|
CodSpeed Performance ReportMerging #817 will not alter performanceComparing Summary
|
Looks like the PR still has a red cross, but the actions CI status is successful: https://github.com/pydantic/pydantic-core/actions/runs/5645640678 |
More importantly, people won't get emails notifying of CI run failure. |
please review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
doesn't seem to make that much difference? We still get the cross, so the PR still shows as failing. |
As per comments above, the red cross is still there but the actions run succeeds so no email notifying of failure. |
Change Summary
At the moment CI is red on all runs because of
test-pydantic-integration
. I believe that using GHA'scontinue-on-error
setting will have the same functionality as thealls-green
check however will also mean the PR gets a green tick.Related issue number
N/A
Checklist
pydantic-core
(except for expected changes)Selected Reviewer: @dmontagu