Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

correct name of "AssignmentValidatorCallable" #789

Merged
merged 1 commit into from
Jul 19, 2023

Conversation

davidhewitt
Copy link
Contributor

@davidhewitt davidhewitt commented Jul 19, 2023

Change Summary

I noticed this inconsistency that AssignmentValidatorCallable was being created with a name of "ValidatorCallable". Was it intended?

Related issue number

N/A

Checklist

  • Unit tests for the changes exist
  • Documentation reflects the changes where applicable
  • Pydantic tests pass with this pydantic-core (except for expected changes)
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

Selected Reviewer: @samuelcolvin

@davidhewitt
Copy link
Contributor Author

please review

@codecov
Copy link

codecov bot commented Jul 19, 2023

Codecov Report

Merging #789 (e9d7bfd) into main (68453df) will not change coverage.
The diff coverage is 100.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #789   +/-   ##
=======================================
  Coverage   93.53%   93.53%           
=======================================
  Files         100      100           
  Lines       14376    14376           
  Branches       25       25           
=======================================
  Hits        13446    13446           
  Misses        924      924           
  Partials        6        6           
Impacted Files Coverage Δ
src/validators/function.rs 90.65% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 68453df...e9d7bfd. Read the comment docs.

@codspeed-hq
Copy link

codspeed-hq bot commented Jul 19, 2023

CodSpeed Performance Report

Merging #789 will not alter performance

Comparing dh/validator-callable (e9d7bfd) with main (68453df)

Summary

✅ 126 untouched benchmarks

@davidhewitt davidhewitt merged commit 7212044 into main Jul 19, 2023
@davidhewitt davidhewitt deleted the dh/validator-callable branch July 19, 2023 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants