Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add serialization key to InvalidSchema #1482

Merged
merged 2 commits into from
Oct 15, 2024
Merged

Add serialization key to InvalidSchema #1482

merged 2 commits into from
Oct 15, 2024

Conversation

sydney-runkle
Copy link
Member

@sydney-runkle sydney-runkle commented Oct 11, 2024

Copy link

codspeed-hq bot commented Oct 11, 2024

CodSpeed Performance Report

Merging #1482 will not alter performance

Comparing invalid-fix (475cb3b) with main (bbd4de5)

Summary

✅ 155 untouched benchmarks

Copy link
Contributor

@davidhewitt davidhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The patch looks reasonable, but the PR title seems to describe something completely different?

@sydney-runkle sydney-runkle changed the title Remove InvalidSchema from CoreSchema for typing purposes Add serialization key to InvalidSchema Oct 15, 2024
@sydney-runkle
Copy link
Member Author

The patch looks reasonable, but the PR title seems to describe something completely different?

Fixed, thanks.

Copy link
Contributor

@davidhewitt davidhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM

.github/workflows/ci.yml Outdated Show resolved Hide resolved
@sydney-runkle sydney-runkle merged commit c38a68d into main Oct 15, 2024
28 of 29 checks passed
@sydney-runkle sydney-runkle deleted the invalid-fix branch October 15, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants