Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix union validation logic when extra='allow' #1334

Merged
merged 1 commit into from
Jun 20, 2024
Merged

Fix union validation logic when extra='allow' #1334

merged 1 commit into from
Jun 20, 2024

Conversation

sydney-runkle
Copy link
Member

@sydney-runkle sydney-runkle mentioned this pull request Jun 19, 2024
Open
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Jun 19, 2024

CodSpeed Performance Report

Merging #1334 will not alter performance

Comparing extra-fields-set-fix (6550529) with main (fcc77f8)

Summary

✅ 155 untouched benchmarks

davidhewitt
davidhewitt approved these changes Jun 20, 2024
View reviewed changes
Copy link
Contributor

@davidhewitt davidhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely simplification which also improves things further :)

@sydney-runkle sydney-runkle merged commit a65f327 into main Jun 20, 2024
28 checks passed
@sydney-runkle sydney-runkle deleted the extra-fields-set-fix branch June 20, 2024 12:12
This was referenced Jul 8, 2024
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidhewitt davidhewitt davidhewitt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improved smart union behaviour when extra="allow" or extra="ignore" and union members have no required fields
2 participants
@sydney-runkle @davidhewitt