-
Notifications
You must be signed in to change notification settings - Fork 250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
restore pypy builds for x86_64 #1072
Conversation
280832b
to
d7653a5
Compare
CodSpeed Performance ReportMerging #1072 will degrade performances by 24.61%Comparing Summary
Benchmarks breakdown
|
2a57372
to
8e218c1
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1072 +/- ##
=======================================
Coverage 89.63% 89.63%
=======================================
Files 106 106
Lines 16391 16391
Branches 35 35
=======================================
Hits 14692 14692
Misses 1692 1692
Partials 7 7 Continue to review full report in Codecov by Sentry.
|
e631556
to
df4e8ac
Compare
please review |
exclude: | ||
- os: macos-latest-xlarge | ||
# macos arm only supported from 3.10 and up |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hi @davidhewitt! could you pls explain this comment? Thank you
upd. i mean as far as i know (and use) apple silicon is supported since python 3.8
upd2. ah. that's just because of actions/setup-python@v5
? xd
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes that was purely limited by what we could download to run the build, IIRC.
Change Summary
Reworks CI to include x86_64 pypy builds, which were removed from PGO optimization in #1063
I restructured the build matrix a bit into something which is hopefully a bit more obvious what we're choosing to build.
Related issue number
Fixes #1071
Checklist
pydantic-core
(except for expected changes)Selected Reviewer: @adriangb