Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

restore pypy builds for x86_64 #1072

Merged
merged 1 commit into from
Nov 14, 2023
Merged

restore pypy builds for x86_64 #1072

merged 1 commit into from
Nov 14, 2023

Conversation

davidhewitt
Copy link
Contributor

@davidhewitt davidhewitt commented Nov 14, 2023

Change Summary

Reworks CI to include x86_64 pypy builds, which were removed from PGO optimization in #1063

I restructured the build matrix a bit into something which is hopefully a bit more obvious what we're choosing to build.

Related issue number

Fixes #1071

Checklist

  • Unit tests for the changes exist
  • Documentation reflects the changes where applicable
  • Pydantic tests pass with this pydantic-core (except for expected changes)
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

Selected Reviewer: @adriangb

@davidhewitt davidhewitt added the Full Build cause CI to do a full build label Nov 14, 2023
@davidhewitt davidhewitt force-pushed the dh/rework-build-matrix branch from 280832b to d7653a5 Compare November 14, 2023 10:53
Copy link

codspeed-hq bot commented Nov 14, 2023

CodSpeed Performance Report

Merging #1072 will degrade performances by 24.61%

Comparing dh/rework-build-matrix (df4e8ac) with main (baed943)

Summary

❌ 1 regressions
✅ 139 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main dh/rework-build-matrix Change
test_dont_raise_error 29.3 µs 38.9 µs -24.61%

@davidhewitt davidhewitt force-pushed the dh/rework-build-matrix branch 4 times, most recently from 2a57372 to 8e218c1 Compare November 14, 2023 11:03
Copy link

codecov bot commented Nov 14, 2023

Codecov Report

Merging #1072 (df4e8ac) into main (fbae08c) will not change coverage.
Report is 1 commits behind head on main.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1072   +/-   ##
=======================================
  Coverage   89.63%   89.63%           
=======================================
  Files         106      106           
  Lines       16391    16391           
  Branches       35       35           
=======================================
  Hits        14692    14692           
  Misses       1692     1692           
  Partials        7        7           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update baed943...df4e8ac. Read the comment docs.

@davidhewitt davidhewitt force-pushed the dh/rework-build-matrix branch 12 times, most recently from e631556 to df4e8ac Compare November 14, 2023 11:26
@davidhewitt
Copy link
Contributor Author

please review

@davidhewitt davidhewitt merged commit a35b182 into main Nov 14, 2023
51 of 56 checks passed
@davidhewitt davidhewitt deleted the dh/rework-build-matrix branch November 14, 2023 14:12
exclude:
- os: macos-latest-xlarge
# macos arm only supported from 3.10 and up
Copy link

@MarshalX MarshalX Mar 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @davidhewitt! could you pls explain this comment? Thank you

upd. i mean as far as i know (and use) apple silicon is supported since python 3.8
upd2. ah. that's just because of actions/setup-python@v5? xd

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes that was purely limited by what we could download to run the build, IIRC.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Full Build cause CI to do a full build ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pydantic_core-2.14.1-pp310-pypy310_pp73-manylinux_2_17_x86_64.manylinux2014_x86_64.whl is missing.
3 participants