Add enable_parallel_tool_calls to OpenAIModel
#633
+16
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…an be disabled to support Azure's outdated OpenAI API instance. Fixes pydantic#169
samuelcolvin
reviewed
Jan 7, 2025
samuelcolvin
requested changes
Jan 7, 2025
| assert str(m.client.base_url) == 'https://api.openai.com/v1/' | ||
| assert m.client.api_key == 'foobar' | ||
| assert m.name() == 'openai:gpt-4' | ||
| assert m.enable_parallel_tool_calls is False |
There was a problem hiding this comment.
This doesn't really test very much, we should check that that this changes the request made to OpenAI.
There are other tests in this file that should give you a hint as to what to do.
There was a problem hiding this comment.
I believe the OpenAIAgentModel._completions_create method is effectively untested because of the way MockOpenAI is constructed in the tests (i.e. overriding that method), so testing the passing of any kwargs to self.chat.completions.create (openai.py L193) would require changing/making a new mock class. Can you confirm if that is accurate?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation as per this comment: #169 (comment)
Fix #169