Adds dynamic to system_prompt decorator, allowing reevaluation #560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samuelcolvin
requested changes
Dec 30, 2024
| @@ -526,16 +526,37 @@ def system_prompt(self, func: Callable[[], str], /) -> Callable[[], str]: ... | |||
| @overload | |||
| def system_prompt(self, func: Callable[[], Awaitable[str]], /) -> Callable[[], Awaitable[str]]: ... | |||
|
|
|||
| @overload | |||
| def system_prompt( | |||
| self, func: _system_prompt.SystemPromptFunc[AgentDeps] | None = None, /, *, dynamic: bool = False | |||
There was a problem hiding this comment.
I think this overload can't have func, so the signature is just (self, *, dynamic: bool = False)
| @@ -830,8 +855,8 @@ async def add_tool(tool: Tool[AgentDeps]) -> None: | |||
| ) | |||
|
|
|||
| async def _prepare_messages( | |||
| self, user_prompt: str, message_history: list[_messages.ModelMessage] | None, run_context: RunContext[AgentDeps] | |||
| ) -> list[_messages.ModelMessage]: | |||
| self, user_prompt: str, message_history: list[_messages.ModelMessage] | None, run_context: RunContext[AgentDeps] | |||
There was a problem hiding this comment.
I don't think this should have changed.
tests/test_agent.py
Outdated
| ] | ||
| ) | ||
|
|
||
| def test_messages_history_reevaluate_system_prompt_dirty(set_event_loop: None): |
There was a problem hiding this comment.
I don't understand what these tests are testing.
Please add a doctring, but also I think there are more tests here than really necessary.
Co-authored-by: Samuel Colvin <[email protected]>
|
@samuelcolvin I'm reviewing this, since I found a bug, when using dynamic=True on one decorator it reevaluates (builds) all other sys_parts. I will have to make a discrimination or annotate the message once is built. |
|
Hey @josead |
|
I will commit Tomorrow, but yes I have an approach
El mar, 31 de dic de 2024, 7:59 p. m., Hamza Farhan <
***@***.***> escribió:
… Hey @josead <https://github.com/josead>
Were you able to solve the issue?
—
Reply to this email directly, view it on GitHub
<#560 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABM4XWN43HEPZTA3E7AFMDT2IMOUZAVCNFSM6AAAAABUKEBRB2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNRWG42DIOBXHA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds optional parameter "dynamic" to decorator "system_prompt".
Implements the reevaluation of system prompts.
Allows new prompts to be added only if they are dynamic.
Hello Pydantic Team,
In response to this issue I've created #531
Let me know if this is a good approach for the enhancement.
CC: @samuelcolvin @sydney-runkle
Regards!