Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop psycopg kwargs #768

Merged
merged 7 commits into from
Jan 6, 2025
Merged

Drop psycopg kwargs #768

merged 7 commits into from
Jan 6, 2025

Conversation

Kludex
Copy link
Member

@Kludex Kludex commented Jan 2, 2025

No description provided.

@Kludex Kludex requested a review from alexmojaki January 2, 2025 11:55
Copy link

cloudflare-workers-and-pages bot commented Jan 2, 2025

Deploying logfire-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 4ff4c0d
Status: ✅  Deploy successful!
Preview URL: https://263061f1.logfire-docs.pages.dev
Branch Preview URL: https://drop-psycopg-kwargs.logfire-docs.pages.dev

View logs

@alexmojaki
Copy link
Contributor

CommenterOptions isn't in the docs.

Copy link
Contributor

@hyperlint-ai hyperlint-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The style guide flagged several spelling errors that seemed like false positives. We skipped posting inline suggestions for the following words:

  • [Hh]eading_level
  • [Ss]how_root_doc_entry
  • [Ss]how_source
  • [Ss]how_root_heading
  • [Ss]how_root_full_path

Copy link

codecov bot commented Jan 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (1fb4694) to head (4ff4c0d).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #768   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          137       137           
  Lines        10963     10968    +5     
  Branches       778       779    +1     
=========================================
+ Hits         10963     10968    +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Kludex Kludex merged commit 5f9dd90 into main Jan 6, 2025
17 checks passed
@Kludex Kludex deleted the drop-psycopg-kwargs branch January 6, 2025 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants