Drop httpx kwargs #751
Merged
Drop httpx kwargs #751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kludex
commented
Dec 30, 2024
Comment on lines
+1281
to
+1284
| request_hook: A function called right after a span is created for a request. | ||
| response_hook: A function called right before a span is finished for the response. | ||
| async_request_hook: A function called right after a span is created for an async request. | ||
| async_response_hook: A function called right before a span is finished for an async response. |
There was a problem hiding this comment.
Please apply anything you'd like here.
There was a problem hiding this comment.
I do think we should improve this but it'll be easier to do that along with other docs, so let's merge this PR because it's easily an improvement but keep this whole docstring in mind.
Deploying logfire-docs with
|
| Latest commit: |
79b80c1
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://f9064418.logfire-docs.pages.dev |
| Branch Preview URL: | https://drop-httpx-kwargs.logfire-docs.pages.dev |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #751 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 135 135
Lines 10916 10912 -4
Branches 1549 1549
=========================================
- Hits 10916 10912 -4 ☔ View full report in Codecov by Sentry. |
Kludex
commented
Dec 31, 2024
alexmojaki
approved these changes
Dec 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.