httpx: support capture_headers
#719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying logfire-docs with
|
| Latest commit: |
c7f89f1
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://a695e569.logfire-docs.pages.dev |
| Branch Preview URL: | https://document-httpx-integration.logfire-docs.pages.dev |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #719 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 137 138 +1
Lines 11059 11088 +29
Branches 1546 1548 +2
=========================================
+ Hits 11059 11088 +29 ☔ View full report in Codecov by Sentry. |
alexmojaki
approved these changes
Dec 23, 2024
|
|
||
| import httpx | ||
| import opentelemetry.sdk.trace | ||
|
|
||
| from logfire.integrations.httpx import ( |
There was a problem hiding this comment.
Move this under TYPE_CHECKING so that the except ImportError: will still work if logfire.integrations.httpx starts importing from otel
There was a problem hiding this comment.
It still works like this, cause httpx is supposed to be installed here, and opentelemetry.trace as well.
There was a problem hiding this comment.
i'm referring to this:
# TODO(Marcelo): When https://github.com/open-telemetry/opentelemetry-python-contrib/pull/3098/ gets merged,
# and the next version of `opentelemetry-instrumentation-httpx` is released, we can just do a reimport:
# from opentelemetry.instrumentation.httpx import RequestInfo as RequestInfo
# from opentelemetry.instrumentation.httpx import ResponseInfo as ResponseInfo
# from opentelemetry.instrumentation.httpx import RequestHook as RequestHook
# from opentelemetry.instrumentation.httpx import ResponseHook as ResponseHook
|
ah, you approved. I've applied all comments |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.