Remove double record exception #712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying logfire-docs with
|
| Latest commit: |
a07384e
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://6504c716.logfire-docs.pages.dev |
| Branch Preview URL: | https://remove-double-record-excepti.logfire-docs.pages.dev |
dmontagu
commented
Dec 20, 2024
dmontagu
commented
Dec 20, 2024
dmontagu
commented
Dec 20, 2024
dmontagu
commented
Dec 20, 2024
dmontagu
commented
Dec 20, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #712 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 137 137
Lines 10911 10925 +14
Branches 781 781
=========================================
+ Hits 10911 10925 +14 ☔ View full report in Codecov by Sentry. |
dmontagu
commented
Dec 20, 2024
dmontagu
commented
Dec 20, 2024
alexmojaki
approved these changes
Dec 23, 2024
|
@alexmojaki I see you approved this, but just to confirm, am I good to merge this now? I can make additional changes if there's anything left you prefer |
alexmojaki
reviewed
Jan 2, 2025
alexmojaki
reviewed
Jan 3, 2025
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are currently double-recording exceptions in LogfireSpan's due to some convoluted logic that this PR simplifies