Preserve docstrings in auto-tracing #550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying logfire-docs with
|
| Latest commit: |
6bb07cf
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://0d7ad6bd.logfire-docs.pages.dev |
| Branch Preview URL: | https://alex-fix-autotrace-docstring.logfire-docs.pages.dev |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #550 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 132 132
Lines 10095 10100 +5
Branches 1367 1368 +1
=========================================
+ Hits 10095 10100 +5 ☔ View full report in Codecov by Sentry. |
davidhewitt
reviewed
Oct 29, 2024
| new_body: list[ast.stmt] = [] | ||
| if ( | ||
| body | ||
| and isinstance(body[0], ast.Expr) |
There was a problem hiding this comment.
I suppose it is guaranteed that 0 must exist (even if it is just pass or ...)?
There was a problem hiding this comment.
I'm pretty sure it is, but I started the condition with body and just in case.
There was a problem hiding this comment.
Ah right, at this point Rust's lack of "empty collection is not truthy" has eroded this from my mind 😂
|
All looks good to me, sorry for the late review 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #440