-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add release automation logic #504
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 files reviewed, 1 total issue(s) found.
The style guide flagged several spelling errors that seemed like false positives. We skipped posting inline suggestions for the following words:
- gh
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #504 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 132 132
Lines 9961 9961
Branches 1341 1341
=========================================
Hits 9961 9961 ☔ View full report in Codecov by Sentry. |
Co-authored-by: hyperlint-ai[bot] <154288675+hyperlint-ai[bot]@users.noreply.github.com>
Deploying logfire-docs with Cloudflare Pages
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 files reviewed, 1 total issue(s) found.
The style guide flagged several spelling errors that seemed like false positives. We skipped posting inline suggestions for the following words:
- approx_percentile_cont
This reverts commit b93420d.
@@ -311,45 +311,45 @@ First release from new repo! | |||
* Ensure `logfire.testing` doesn't depend on pydantic and eval_type_backport by @alexmojaki in https://github.com/pydantic/logfire/pull/40 | |||
* Allow using pydantic plugin with models defined before calling logfire.configure by @alexmojaki in https://github.com/pydantic/logfire/pull/36 | |||
|
|||
[v1.1.0]: https://github.com/pydantic/logfire/compare/v1.0.1...v1.1.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reversed the order here so that we can simply append in the future
Thank you! I haven't reviewed the code because I don't think there's really a need, if there's issues we'll discover them. |
Closes #470
See readme for new pattern:
Sample draft release created: https://github.com/pydantic/logfire/releases/tag/untagged-f0b744b87f685d76bbd2
Sample PR (note, I've changed the base for clarity, but normally it would be against
main
): #511Looks like I updated stubs as well 🤷♀️