Add the logfire.instrument_mysql()

[aditkumar72]

Fixes #310

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (b185a55) to head (616837a).

Additional details and impacted files

@@            Coverage Diff            @@
##              main      #341   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          119       121    +2     
  Lines         8895      8947   +52     
  Branches      1159      1162    +3     
=========================================
+ Hits          8895      8947   +52     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[aditkumar72]

@Kludex Could you please review the PR ?

[Kludex]

On this integration, you can also instrument a single connection.

@alexmojaki Can you confirm we want this to be analogous to psycopg?

[alexmojaki]

We do want that, but I don't know if that needs to block this PR.

[aditkumar72]

@Kludex @alexmojaki I will update this PR instrumenting single MySQL connection, as this is not an urgent required changes

[aditkumar72]

@Kludex updated the PR, Could you please review ?

[aditkumar72]

Hi @alexmojaki , resolved the comments. Could you please review ?

[aditkumar72]

@alexmojaki Could you please review the changes ?

[Kludex]

Suggested change

	Args:
	conn: The `mysql` connection to instrument, or `None` to instrument all connections.
	**kwargs: Additional keyword arguments to pass to the OpenTelemetry `instrument` methods.
	Returns:
	If a connection is provided, returns the instrumented connection. If no connection is provided, returns None.

[alexmojaki]

I think this is fine. We have something similar in instrument_psycopg. All of this is useful, especially the fact that it returns an instrumented connection.

[Kludex]

Suggested change

	Args:
	conn: The MySQL connection to instrument. If None, the entire `mysql` module is instrumented.
	**kwargs: Additional keyword arguments to pass to the OpenTelemetry `instrument` methods.
	Returns:
	If a connection is provided, returns the instrumented connection. If no connection is provided, returns None.

[Kludex]

Suggested change

	Args:
	conn: The `mysql` connection to instrument, or `None` to instrument all connections.
	**kwargs: Additional keyword arguments to pass to the OpenTelemetry `instrument` methods.
	Returns:
	If a connection is provided, returns the instrumented connection. If no connection is provided, returns None.

[Kludex]

Suggested change

	Args:
	conn: The MySQL connection to instrument. If None, the entire `mysql` module is instrumented.
	**kwargs: Additional keyword arguments to pass to the OpenTelemetry `instrument` methods.
	Returns:
	If a connection is provided, returns the instrumented connection. If no connection is provided, returns None.

[aditkumar72]

@Kludex please check this comment #341 (comment)
Do we need to remove those doc strings ?

[Kludex]

Thanks @aditkumar72 🙏