Fix and test unmapped SQLModels #286
Merged
+53
−36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
Deploying logfire-docs with
|
| Latest commit: |
99cd67c
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://2fcdd793.logfire-docs.pages.dev |
| Branch Preview URL: | https://alex-sqlmodel.logfire-docs.pages.dev |
|
This PR breaks stubgen on the Traceback from Traceback (most recent call last):
File "/Users/marcelotryle/dev/pydantic/logfire/.venv/bin/stubgen", line 8, in <module>
sys.exit(main())
^^^^^^
File "mypy/stubgen.py", line 1882, in main
File "mypy/stubgen.py", line 1678, in generate_stubs
File "mypy/stubgen.py", line 1610, in generate_asts_for_modules
File "mypy/build.py", line 192, in build
File "mypy/build.py", line 266, in _build
File "mypy/build.py", line 2942, in dispatch
File "mypy/build.py", line 3340, in process_graph
File "mypy/build.py", line 3468, in process_stale_scc
File "mypy/build.py", line 2503, in write_cache
File "mypy/build.py", line 1564, in write_cache
File "mypy/nodes.py", line 387, in serialize
File "mypy/nodes.py", line 3936, in serialize
File "mypy/nodes.py", line 3873, in serialize
File "mypy/nodes.py", line 3304, in serialize
File "mypy/types.py", line 667, in serialize
File "mypy/types.py", line 2430, in serialize
File "mypy/types.py", line 1468, in serialize
File "mypy/types.py", line 667, in serialize
File "mypy/types.py", line 3067, in serialize
AssertionError: Internal error: unresolved placeholder type None |
Kludex
reviewed
Jul 5, 2024
| @@ -173,9 +173,9 @@ mypy-extensions==1.0.0 | |||
| nodeenv==1.9.1 | |||
| # via pre-commit | |||
| # via pyright | |||
| numpy==1.26.4 | |||
| numpy==2.0.0 | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #276
Also upgraded lockfile versions while I was at it.