Default the log level to error if the status code is error, and vice versa #269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
Deploying logfire-docs with
|
| Latest commit: |
09b1eae
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://6f1dbad4.logfire-docs.pages.dev |
| Branch Preview URL: | https://alex-level-error.logfire-docs.pages.dev |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
otel_status_codeisERRORand the log level is unset, then the log level is set to error. This way a query forlevel >= level_num('error')will generally find all kinds of errors.otel_status_codeisUNSET, thenotel_status_codeis set toERROR. This means thatotel_status_code = 'ERROR'will find all errors in the same way. I think I've seen some users queryingotel_status_codeso this will make that easy and discoverable, whereas queryinglevelis not super user-friendly.