Skip to content

Commit

Permalink
Remove urllib3 thing from dev deps
Browse files Browse the repository at this point in the history
  • Loading branch information
dmontagu committed Aug 30, 2024
1 parent c6185e6 commit c2a81be
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 17 deletions.
11 changes: 0 additions & 11 deletions .hyperlint/style_guide_test.md

This file was deleted.

10 changes: 5 additions & 5 deletions logfire/experimental/query_client.py
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
try:
from httpx import AsyncClient, Client, Response, Timeout
from httpx._client import BaseClient
except ImportError as e:
except ImportError as e: # pragma: no cover
raise ImportError('httpx is required to use the Logfire query clients') from e

if TYPE_CHECKING:
Expand Down Expand Up @@ -89,9 +89,9 @@ def build_query_params(
return params

def handle_response_errors(self, response: Response) -> None:
if response.status_code == 400:
if response.status_code == 400: # pragma: no cover
raise QueryExecutionError(response.json())
if response.status_code == 422:
if response.status_code == 422: # pragma: no cover
raise QueryRequestError(response.json())
assert response.status_code == 200, response.content

Expand Down Expand Up @@ -171,7 +171,7 @@ def query_arrow( # type: ignore
"""
try:
import pyarrow
except ImportError as e:
except ImportError as e: # pragma: no cover
raise ImportError('pyarrow is required to use the query_arrow method') from e

response = self._query(
Expand Down Expand Up @@ -295,7 +295,7 @@ async def query_arrow( # type: ignore
"""
try:
import pyarrow
except ImportError as e:
except ImportError as e: # pragma: no cover
raise ImportError('pyarrow is required to use the query_arrow method') from e

response = await self._query(
Expand Down
1 change: 0 additions & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,6 @@ dev-dependencies = [
"griffe==0.48.0",
"pyarrow>=17.0.0",
"pytest-recording>=0.13.2",
'urllib3<2; python_version < "3.10"'
]

[tool.rye.scripts]
Expand Down

0 comments on commit c2a81be

Please sign in to comment.