Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix compatibility with deployed static sites #26

Merged
merged 3 commits into from
Oct 26, 2021
Merged

Fix compatibility with deployed static sites #26

merged 3 commits into from
Oct 26, 2021

Conversation

josix
Copy link
Contributor

@josix josix commented Oct 25, 2021

Fix #25

  • Unify intake path through urlparser to prevent taking value https://xxxx as path
  • Add pipenv script command to run server

@josix josix changed the title Fix compatibility with deployed sites Fix compatibility with deployed static sites Oct 25, 2021
@josix josix requested a review from mattwang44 October 25, 2021 10:32
mattwang44
mattwang44 approved these changes Oct 25, 2021
View reviewed changes
Copy link
Member

@mattwang44 mattwang44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Lee-W
Lee-W reviewed Oct 25, 2021
View reviewed changes
Pipfile Outdated
@@ -13,3 +13,6 @@ beautifulsoup4 = "~=4.10.0"

[requires]
python_version = "3.9"

[scripts]
server = "python -m http.server --cgi 5000"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick: tools like pelican seems to use the word serve instead of server

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I've fixed it.

@josix josix requested a review from Lee-W October 25, 2021 16:46
@josix josix merged commit d1ebba5 into pycontw:main Oct 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattwang44 mattwang44 mattwang44 approved these changes

@Lee-W Lee-W Lee-W approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Recent deployment break scrapper's functionality
3 participants
@josix @Lee-W @mattwang44