Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(sponsor): remove sponsor-related deprecated code #1133

Merged
merged 9 commits into from
Apr 24, 2024

Conversation

mattwang44
Copy link
Member

@mattwang44 mattwang44 commented Mar 16, 2023

Types of changes

  • Bugfix
  • New feature
  • Refactoring
  • Breaking change (any change that would cause existing functionality to not work as expected)
  • Documentation Update
  • Other (please describe)

Description

remove deprecated sponsor-related code

Note that I only modified/deleted those templates and static from 2023 code.

@mattwang44 mattwang44 force-pushed the clean-sponsor-app branch 4 times, most recently from 422d07d to 1acf4c9 Compare March 16, 2023 06:30
@codecov-commenter
Copy link

codecov-commenter commented Mar 16, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.99%. Comparing base (134b60e) to head (0303af9).

Additional details and impacted files
@@                       Coverage Diff                       @@
##           rm-schedule-model-and-views    #1133      +/-   ##
===============================================================
+ Coverage                        73.16%   73.99%   +0.83%     
===============================================================
  Files                               83       81       -2     
  Lines                             3115     3057      -58     
===============================================================
- Hits                              2279     2262      -17     
+ Misses                             836      795      -41     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mattwang44
Copy link
Member Author

@Ritabear please review the unit tests of sponsor API

@mattwang44 mattwang44 marked this pull request as ready for review March 16, 2023 06:38
@josix josix requested a review from erik1110 April 8, 2023 02:30
@mattwang44
Copy link
Member Author

@SivanYeh @erik1110 please join as the reviewer for the unit test part, thanks!

@mattwang44
Copy link
Member Author

@erik1110 @SivanYeh any progress here?

@erik1110
Copy link
Contributor

@erik1110 @SivanYeh any progress here?
"I have set up the environment and am currently researching how to write test examples. I have left some questions in the discussion thread."

@SivanYeh
Copy link
Collaborator

SivanYeh commented Jun 18, 2023

@erik1110 @SivanYeh any progress here?
@mattwang44 Same as Erik. Yet Josix may assign it to other member because of the approaching due.
I would continue reading codes and asking.

@mattwang44
Copy link
Member Author

will rebase again after #1132 is merged

@mattwang44
Copy link
Member Author

Please let me know if this refactoring PR is either unwanted or still wanted. I wouldn't take any further action for now as it has been forgotten for quite a long time....

@SivanYeh
Copy link
Collaborator

SivanYeh commented Apr 5, 2024

@mattwang44 LGTM. I will resolve the conflix and create a new PR on src/templates/pycontw-2024 with similar redundancy

@mattwang44 mattwang44 force-pushed the rm-schedule-model-and-views branch 5 times, most recently from 88b87eb to 134b60e Compare April 15, 2024 09:15
@mattwang44
Copy link
Member Author

rebased

Copy link
Collaborator

@SivanYeh SivanYeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mattwang44 mattwang44 changed the base branch from rm-schedule-model-and-views to master April 24, 2024 09:53
@mattwang44 mattwang44 merged commit 5de4d15 into master Apr 24, 2024
3 checks passed
@mattwang44 mattwang44 deleted the clean-sponsor-app branch April 24, 2024 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants