-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(sponsor): remove sponsor-related deprecated code #1133
Conversation
422d07d
to
1acf4c9
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## rm-schedule-model-and-views #1133 +/- ##
===============================================================
+ Coverage 73.16% 73.99% +0.83%
===============================================================
Files 83 81 -2
Lines 3115 3057 -58
===============================================================
- Hits 2279 2262 -17
+ Misses 836 795 -41 ☔ View full report in Codecov by Sentry. |
@Ritabear please review the unit tests of sponsor API |
1acf4c9
to
ca6fc72
Compare
|
d012727
to
d5e160a
Compare
will rebase again after #1132 is merged |
Please let me know if this refactoring PR is either unwanted or still wanted. I wouldn't take any further action for now as it has been forgotten for quite a long time.... |
@mattwang44 LGTM. I will resolve the conflix and create a new PR on src/templates/pycontw-2024 with similar redundancy |
88b87eb
to
134b60e
Compare
e3ac5fb
to
0369e2d
Compare
0369e2d
to
0303af9
Compare
rebased |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Types of changes
Description
remove deprecated sponsor-related code
Note that I only modified/deleted those templates and static from 2023 code.