-
-
Notifications
You must be signed in to change notification settings - Fork 866
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to persist cookies #1720
base: main
Are you sure you want to change the base?
Conversation
* Change `auth` param from tuple to dict to support optional `cookie_jar` param. * Add option to provide callable for lazy password fetching.
e0bac5f
to
eb3a752
Compare
fixes #883 |
auth (Optional[Tuple[str,str]]): Set a cookie auth token if this is required. | ||
|
||
auth (Optional[Dict[str, Any]]): A dict of properties for Cookei authentication. | ||
The following properties are available: | ||
|
||
* username (srt) -- username | ||
* password (str | Callable[[], str]) -- password or function for lazy receiving password | ||
* cookie_jar (Optional[srt]) -- file path for persisting cookies | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be better if we can support both tuple and dict, with a deprecation warning for the tuple. As we need to consider all users
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(as mentioned please look into supporting existing use case too)
auth
param from tuple to dict to support optionalcookie_jar
param.