Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix program hanging when gzip_ng_threaded.open is used without a context manager and program crashes #54

Merged
merged 2 commits into from
Sep 13, 2024

Conversation

rhpvorderman
Copy link
Contributor

@rhpvorderman rhpvorderman commented Sep 11, 2024

Fixes #53

Checklist

  • Pull request details were added to CHANGELOG.rst
  • Documentation was updated (if needed)

@rhpvorderman rhpvorderman changed the title Issue53 Fix program hanging when gzip_ng_threaded.open is used without a context manager and program crashes Sep 11, 2024
Copy link

codecov bot commented Sep 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.77%. Comparing base (36b722f) to head (c6329c2).
Report is 23 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #54      +/-   ##
===========================================
+ Coverage    94.46%   94.77%   +0.30%     
===========================================
  Files            3        3              
  Lines          452      440      -12     
  Branches        83       77       -6     
===========================================
- Hits           427      417      -10     
+ Misses          15       14       -1     
+ Partials        10        9       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gzip_ng_threaded prevents programs from crashing if a file is open
1 participant