Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed the deprecated md5 default on CRL.export() #652

Merged
merged 6 commits into from
Jun 30, 2017
Merged

Removed the deprecated md5 default on CRL.export() #652

merged 6 commits into from
Jun 30, 2017

Conversation

alex
Copy link
Member

@alex alex commented Jun 30, 2017

No description provided.

Lukasa
Lukasa previously approved these changes Jun 30, 2017
View reviewed changes
Copy link
Member

@Lukasa Lukasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we can merge when green.

hynek
hynek previously approved these changes Jun 30, 2017
View reviewed changes
@alex alex dismissed stale reviews from hynek and Lukasa via 7dfbd24 June 30, 2017 14:27
@codecov
Copy link

codecov bot commented Jun 30, 2017 •
edited
Loading

Codecov Report

Merging #652 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #652      +/-   ##
==========================================
- Coverage   96.95%   96.94%   -0.01%     
==========================================
  Files          18       18              
  Lines        5740     5734       -6     
  Branches      401      401              
==========================================
- Hits         5565     5559       -6     
  Misses        117      117              
  Partials       58       58
Impacted Files Coverage Δ
src/OpenSSL/crypto.py 96.8% <100%> (-0.01%) ⬇️
tests/test_crypto.py 98.61% <100%> (-0.01%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 941f903...d996411. Read the comment docs.

@codecov
Copy link

codecov bot commented Jun 30, 2017

Codecov Report

Merging #652 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #652      +/-   ##
==========================================
- Coverage   96.95%   96.94%   -0.01%     
==========================================
  Files          18       18              
  Lines        5740     5734       -6     
  Branches      401      401              
==========================================
- Hits         5565     5559       -6     
  Misses        117      117              
  Partials       58       58
Impacted Files Coverage Δ
src/OpenSSL/crypto.py 96.8% <100%> (-0.01%) ⬇️
tests/test_crypto.py 98.61% <100%> (-0.01%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 941f903...d996411. Read the comment docs.

@Lukasa Lukasa merged commit 173e4ba into pyca:master Jun 30, 2017
@alex alex deleted the remove-md5 branch June 30, 2017 15:01
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Lukasa Lukasa Lukasa approved these changes

@hynek hynek hynek left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alex @hynek @Lukasa