Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

py27 going, going, gone #1047

Merged
merged 5 commits into from
Oct 4, 2021
Merged

py27 going, going, gone #1047

merged 5 commits into from
Oct 4, 2021

Conversation

reaperhulk
Copy link
Member

let CI be my guide

njsmith
njsmith approved these changes Oct 4, 2021
View reviewed changes
Copy link
Contributor

@njsmith njsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Codecov seems to be claiming that there's a line somewhere that's no longer being covered, which might mean there's another line that can be removed? I failed at deciphering its output though. Do you care?

@njsmith
Copy link
Contributor

njsmith commented Oct 4, 2021

Meh, having stared at the codecov report some more I'm pretty sure the complaint about new uncovered lines is just some kind of artifact.

@njsmith njsmith merged commit a42ec20 into pyca:main Oct 4, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@njsmith njsmith njsmith approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@reaperhulk @njsmith