Drop manylinux2010

[alex]

It has very low usage

[alex]

Here's the query I used:

SELECT
  file.filename,
  COUNT(*) AS download_count
FROM
  `bigquery-public-data.pypi.file_downloads`
WHERE
  file.project = 'cryptography'
  AND DATE(timestamp) BETWEEN DATE_SUB(CURRENT_DATE(), INTERVAL 30 DAY)
  AND CURRENT_DATE()
  AND file.type = 'bdist_wheel'
  AND file.filename LIKE '%manylinux%'
  AND file.version IN ('35.0.0', '36.0.0')
GROUP BY
  file.filename
HAVING
  download_count >= 100
ORDER BY
  download_count DESC
LIMIT
  100

I then summed up all rows, and all rows where "2010" in filename and divided. Roughly 2% of wheel downloads of recent cryptography versions are manylinux2010.

[tiran]

The 2% are probably AWS Lambda users, see #6391

[alex]

Clean wheel-builder run: https://github.com/pyca/cryptography/actions/runs/1569742750

@tiran does lambda really not support manylinux2014?

[tiran]

@tiran does lambda really not support manylinux2014?

I don't know, I don't use Lambda. #6391 is based on community feedback.

[alex]

It looks like Amazon Linux 2 has a glibc 2.26, so that's fine. If you use AL1 I'm not sure what version of glibc it has, but AL1 appears to be extremely deprecated by Amazon.

[reaperhulk]

I was going to say I wanted to keep this, but manylinux2010 is CentOS 6 derived and that is indeed ancient. The one bit of breakage it seems like we're going to cause here is users who are explicitly passing --plat with the 2010 tag (which seems to mostly be lambda folks). They can switch to 2014 with no ill effects of course, but do we know what AWS is currently recommending in their lambda docs?

[alex]

I can't find any statement in AWS's own docs.

…

On Sun, Dec 12, 2021 at 7:53 PM Paul Kehrer ***@***.***> wrote: I was going to say I wanted to keep this, but manylinux2010 is CentOS 6 derived and that is indeed ancient. The one bit of breakage it seems like we're going to cause here is users who are explicitly passing --plat with the 2010 tag (which seems to mostly be lambda folks). They can switch to 2014 with no ill effects of course, but do we know what AWS is currently recommending in their lambda docs? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#6694 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAAGBDI6NMUUFMSSHKPNYDUQU7XFANCNFSM5J4KZPQA> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

-- All that is necessary for evil to succeed is for good people to do nothing.

[alex]

https://aws.amazon.com/premiumsupport/knowledge-center/lambda-python-package-compatible/ is the one thing I can find... which suggests downloading manylinux1 wheels by hand.

[reaperhulk]

Ouch, who do we know who can agitate to get that fixed... @mattsb42-aws would you know somebody who could update this guidance?

[mattsb42-aws]

I'm not sure who owns that knowledge center doc, but the "Anything we could improve" feedback link (bottom right) should contact the right owners. Ditto on the "Provide feedback" links at the bottom of each docs.aws.amazon.com page. In fact, I would say that knowledge center doc should probably just direct readers to the Lambda docs[1].

I'm not deep in the Lambda Python packaging space anymore, but if AL1 is causing Lambda issues, I suspect that's coming from folks using the Python 3.7 and earlier runtimes[2], since those still use AL1 (and probably always will until they are deprecated.)

[1] https://docs.aws.amazon.com/lambda/latest/dg/python-package.html
[2] https://docs.aws.amazon.com/lambda/latest/dg/lambda-runtimes.html

[reaperhulk]

Thanks Matt, I've sent feedback via the form.

[alex]

Refreshed stats, looking over the past month, and it's now down to 1.5%

[alex]

Metric is down to 0.87% of wheels from 35.x and 36.x being manylinux2010