Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #3492 -- use a better API #3497

Merged
merged 3 commits into from
Apr 9, 2017
Merged

Fixed #3492 -- use a better API #3497

merged 3 commits into from
Apr 9, 2017

Conversation

alex
Copy link
Member

@alex alex commented Apr 8, 2017

No description provided.

@mention-bot
Copy link

@alex, thanks for your PR! By analyzing the history of the files in this pull request, we identified @reaperhulk, @cyli and @public to be potential reviewers.

This reverts commit e741292.
Copy link
Member

@reaperhulk reaperhulk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but would it be possible to add a small test to the memleak section "proving" this properly frees each dist point in the stack? Or is that pointless paranoia?

@alex
Copy link
Member Author

alex commented Apr 9, 2017

The x.509 memleak test already has a vector with a CRLDP

@reaperhulk
Copy link
Member

:dusts hands:

@reaperhulk reaperhulk merged commit a699167 into pyca:master Apr 9, 2017
@alex alex deleted the better-api branch April 9, 2017 13:19
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants