Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Work around for side effects in setup.py script #1257

Closed
wants to merge 10 commits into from
Closed

Work around for side effects in setup.py script #1257

wants to merge 10 commits into from

Commits on Jul 11, 2014

  1. Work around for side effects in setup.py script 

    Disables setup_requires and related magic for setup.py commands
clean, egg_info and sdist and the options --version and --help.

See also #1253
    @xolox
    xolox committed Jul 11, 2014
    Configuration menu
    Copy the full SHA
    2793b6c View commit details
    Browse the repository at this point in the history

  2. Make sys.argv an argument of keywords_with_side_effects()

    @xolox
    xolox committed Jul 11, 2014
    Configuration menu
    Copy the full SHA
    b98089e View commit details
    Browse the repository at this point in the history

  3. Change nested dictionary literal to match house style

    @xolox
    xolox committed Jul 11, 2014
    Configuration menu
    Copy the full SHA
    94cec73 View commit details
    Browse the repository at this point in the history

  4. PEP-8 fixes pointed out by Travis CI

    @xolox
    xolox committed Jul 11, 2014
    Configuration menu
    Copy the full SHA
    7cdddfe View commit details
    Browse the repository at this point in the history

Commits on Jul 12, 2014

  1. Replace commands that depend on setup_requires with no-op that raises… 

    … error
    @xolox
    xolox committed Jul 12, 2014
    Configuration menu
    Copy the full SHA
    6edda86 View commit details
    Browse the repository at this point in the history

  2. Bug fix for implementation of dummy commands 

    Pointed out by Jenkins:
https://jenkins.cryptography.io/job/cryptography-pr-experimental/2163/
    @xolox
    xolox committed Jul 12, 2014
    Configuration menu
    Copy the full SHA
    2705e80 View commit details
    Browse the repository at this point in the history

  3. Bullet proof (?) detection of arguments that don't need setup_requires

    @xolox
    xolox committed Jul 12, 2014
    Configuration menu
    Copy the full SHA
    9e34c14 View commit details
    Browse the repository at this point in the history

Commits on Jul 13, 2014

  1. Simplify dummy commands (fix inheritance, remove finalize_options())

    @xolox
    xolox committed Jul 13, 2014
    Configuration menu
    Copy the full SHA
    b077c15 View commit details
    Browse the repository at this point in the history

Commits on Jul 14, 2014

  1. Fix for keywords_with_side_effects() (compatibility with pip metadata… 

    … discovery)

Fixes a bug in 9e34c14 as described in
#1257 (comment)
    @xolox
    xolox committed Jul 14, 2014
    Configuration menu
    Copy the full SHA
    1784811 View commit details
    Browse the repository at this point in the history

  2. Fix PEP-8 violations

    @xolox
    xolox committed Jul 14, 2014
    Configuration menu
    Copy the full SHA
    cc3b84d View commit details
    Browse the repository at this point in the history