-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes for LogPosterior w/ GaussianLogLikelihood #505
Fixes for LogPosterior w/ GaussianLogLikelihood #505
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #505 +/- ##
========================================
Coverage 99.04% 99.04%
========================================
Files 52 52
Lines 3559 3560 +1
========================================
+ Hits 3525 3526 +1
Misses 34 34 ☔ View full report in Codecov by Sentry. |
@@ -141,7 +141,7 @@ def _add_single_sigma(self, index, value): | |||
Parameter( | |||
f"Sigma for output {index+1}", | |||
initial_value=value, | |||
prior=Uniform(0.5 * value, 1.5 * value), | |||
prior=Uniform(1e-3 * value, 1e3 * value), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is extended to ensure the logpdf of the uniform prior is finite across the search space.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good @BradyPlanden, just a comment for a fix on the posterior class (which to be fair existed before this PR!)
Description
Bug fixes for LogPosterior to integrate with transformed GaussianLogLikelihood.
Issue reference
Fixes # (issue-number)
Review
Before you mark your PR as ready for review, please ensure that you've considered the following:
Type of change
Key checklist:
$ pre-commit run
(or$ nox -s pre-commit
) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)$ nox -s tests
$ nox -s doctest
You can run integration tests, unit tests, and doctests together at once, using
$ nox -s quick
.Further checks:
Thank you for contributing to our project! Your efforts help us to deliver great software.