-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create creating_a_model.ipynb #471
Create creating_a_model.ipynb #471
Conversation
Create a simple script to create a model
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #471 +/- ##
===========================================
+ Coverage 98.76% 99.04% +0.27%
===========================================
Files 48 52 +4
Lines 3153 3545 +392
===========================================
+ Hits 3114 3511 +397
+ Misses 39 34 -5 ☔ View full report in Codecov by Sentry. |
added the possibility to look at the discharge voltage curve of the model.
…://github.com/f-g-r-i-m-m/PyBOP into Try-Example-for-model-creation-pybop-team#282
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @f-g-r-i-m-m, I've made a few updates, but looks great overall.
@all-contributors please add @f-g-r-i-m-m for examples |
I've put up a pull request to add @f-g-r-i-m-m! 🎉 |
Description
Created a notebook for loading a dataset and making an SPM model with it.
Issue reference
Fixes #466
Review
Before you mark your PR as ready for review, please ensure that you've considered the following:
Type of change
Key checklist:
$ pre-commit run
(or$ nox -s pre-commit
) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)$ nox -s tests
$ nox -s doctest
You can run integration tests, unit tests, and doctests together at once, using
$ nox -s quick
.Further checks:
Thank you for contributing to our project! Your efforts help us to deliver great software.