-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds support for IDAKLU w/ output variables #450
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #450 +/- ##
===========================================
- Coverage 98.79% 98.67% -0.13%
===========================================
Files 46 47 +1
Lines 2916 3025 +109
===========================================
+ Hits 2881 2985 +104
- Misses 35 40 +5 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a couple of small comments and a question, but otherwise this looks great! Thanks @BradyPlanden
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @BradyPlanden!
Co-authored-by: NicolaCourtier <[email protected]>
# Conflicts: # CHANGELOG.md
Description
Add support and testing for different pybamm solvers. Includes examples for users to benchmark the different solver for selection of the best on their hardware and situation.
Issue reference
Fixes #160
Review
Before you mark your PR as ready for review, please ensure that you've considered the following:
Type of change
Key checklist:
$ pre-commit run
(or$ nox -s pre-commit
) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)$ nox -s tests
$ nox -s doctest
You can run integration tests, unit tests, and doctests together at once, using
$ nox -s quick
.Further checks:
Thank you for contributing to our project! Your efforts help us to deliver great software.