Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add functional parameter example #442

Merged
merged 8 commits into from
Aug 22, 2024
Merged

Conversation

NicolaCourtier
Copy link
Member

@NicolaCourtier NicolaCourtier commented Aug 6, 2024

Description

Adds an example demonstrating how constants defined within an existing pybamm.FunctionalParameter may be estimated using PyBOP.

Issue reference

Fixes #441.

Review

Before you mark your PR as ready for review, please ensure that you've considered the following:

  • Updated the CHANGELOG.md in reverse chronological order (newest at the top) with a concise description of the changes, including the PR number.
  • Noted any breaking changes, including details on how it might impact existing functionality.

Type of change

  • New Feature: A non-breaking change that adds new functionality.
  • Optimization: A code change that improves performance.
  • Examples: A change to existing or additional examples.
  • Bug Fix: A non-breaking change that addresses an issue.
  • Documentation: Updates to documentation or new documentation for new features.
  • Refactoring: Non-functional changes that improve the codebase.
  • Style: Non-functional changes related to code style (formatting, naming, etc).
  • Testing: Additional tests to improve coverage or confirm functionality.
  • Other: (Insert description of change)

Key checklist:

  • No style issues: $ pre-commit run (or $ nox -s pre-commit) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)
  • All unit tests pass: $ nox -s tests
  • The documentation builds: $ nox -s doctest

You can run integration tests, unit tests, and doctests together at once, using $ nox -s quick.

Further checks:

  • Code is well-commented, especially in complex or unclear areas.
  • Added tests that prove my fix is effective or that my feature works.
  • Checked that coverage remains or improves, and added tests if necessary to maintain or increase coverage.

Thank you for contributing to our project! Your efforts help us to deliver great software.

@NicolaCourtier NicolaCourtier linked an issue Aug 6, 2024 that may be closed by this pull request
Copy link

codecov bot commented Aug 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.76%. Comparing base (6a6b7dd) to head (6783703).
Report is 410 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #442   +/-   ##
========================================
  Coverage    98.76%   98.76%           
========================================
  Files           48       48           
  Lines         3153     3153           
========================================
  Hits          3114     3114           
  Misses          39       39           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@NicolaCourtier NicolaCourtier marked this pull request as ready for review August 8, 2024 11:51
Copy link
Contributor

@brosaplanella brosaplanella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

Copy link
Member

@BradyPlanden BradyPlanden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks brilliant, a few questions/suggestions on the comments, otherwise LGTM!

examples/scripts/functional_parameters.py Outdated Show resolved Hide resolved
examples/scripts/functional_parameters.py Outdated Show resolved Hide resolved
examples/scripts/functional_parameters.py Outdated Show resolved Hide resolved
examples/scripts/functional_parameters.py Outdated Show resolved Hide resolved
@NicolaCourtier NicolaCourtier merged commit 1a76470 into develop Aug 22, 2024
31 checks passed
@NicolaCourtier NicolaCourtier deleted the 441-functional-parameters branch August 22, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add an example that uses a pybamm.FunctionalParameter
3 participants