-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds EIS prediction methods #405
Adds EIS prediction methods #405
Conversation
…ear solve to spsolve, add support for geometric parameters
f1bd83d
to
3c9ce9a
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #405 +/- ##
===========================================
- Coverage 98.77% 98.76% -0.02%
===========================================
Files 48 48
Lines 3193 3153 -40
===========================================
- Hits 3154 3114 -40
Misses 39 39 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
…me' vars to `domain` across codebase, adds initial nyquist plot class
…me' vars to `domain` across codebase, adds initial nyquist plot class
…private member access
…e eis args, correct remainging cost functions for complex numbers
…integration tests
…cation-methods, restore try-except
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, thanks @BradyPlanden !
…ple to be within prior range
Description
This PR adds EIS prediction methods as presented in https://github.com/rish31415/pybamm-eis and https://github.com/pybamm-team/pybamm-eis. These methods are reimplemented into pybop to align with our
model
andproblem
classes. This PR also aligns the dataset requirements for "Time" across the codebase, as the EIS problem is in the frequency domain.To be completed:
EISProblem
and methodmodel.simulateEIS()
)AddThis requires reconstructing the sensitivities, as such is left for a future PR.model.simulateEIS_S1
method w/ new nameAdd eis functionality tomodel.predict()
This PR needs to be merged after PyBaMM v24.5 is released, as well as after #313
Issue reference
Fixes #269
Review
Before you mark your PR as ready for review, please ensure that you've considered the following:
Type of change
Key checklist:
$ pre-commit run
(or$ nox -s pre-commit
) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)$ nox -s tests
$ nox -s doctest
You can run integration tests, unit tests, and doctests together at once, using
$ nox -s quick
.Further checks:
Thank you for contributing to our project! Your efforts help us to deliver great software.