-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a WeightedCost #329
Add a WeightedCost #329
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #329 +/- ##
========================================
Coverage 98.10% 98.10%
========================================
Files 43 44 +1
Lines 2632 2697 +65
========================================
+ Hits 2582 2646 +64
- Misses 50 51 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @NicolaCourtier - this is looking great, I've made some suggestions in 327b to enable the design based costs. I'm happy for this to be merged ahead of that, or to have them merged together and then into develop. Looking forward to this functionality :)
Description
Add a WeightedCost class to combine costs and avoid duplicate problem evaluations where possible.
Issue reference
Fixes #327
Review
Before you mark your PR as ready for review, please ensure that you've considered the following:
Type of change
Key checklist:
$ pre-commit run
(or$ nox -s pre-commit
) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)$ nox -s tests
$ nox -s doctest
You can run integration tests, unit tests, and doctests together at once, using
$ nox -s quick
.Further checks:
Thank you for contributing to our project! Your efforts help us to deliver great software.