Install seed packages (setuptools
and wheel
)
#317
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is a small update to
noxfile.py
where thenox
configuration is updated to install seed packages that can be sometimes missing fromuv
's virtual environments (if usingnox[uv]
). These packages are installed withnox
, which usesvirtualenv
as the backend for creating virtual environments, and therefore this is a failsafe change to ensure that PyBaMM can be installed along with PyBOP for platforms where wheels are not available (macOS ARM wheels started to become available with PyBaMM v24.1).Issue reference
This change hopes to fix some of the failing scheduled tests: https://github.com/pybop-team/PyBOP/actions/runs/8999338828
Review
Before you mark your PR as ready for review, please ensure that you've considered the following:
Type of change
Key checklist:
$ pre-commit run
(or$ nox -s pre-commit
) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)$ nox -s tests
$ nox -s doctest
You can run integration tests, unit tests, and doctests together at once, using
$ nox -s quick
.Further checks:
Thank you for contributing to our project! Your efforts help us to deliver great software.