-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds AdamW optimiser #316
Adds AdamW optimiser #316
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #316 +/- ##
===========================================
+ Coverage 97.09% 97.33% +0.24%
===========================================
Files 42 42
Lines 2410 2404 -6
===========================================
Hits 2340 2340
+ Misses 70 64 -6 ☔ View full report in Codecov by Sentry. |
ac19127
to
c04f0f0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thanks very much @BradyPlanden for the nice addition of the AdamW optimiser. Please update the table in the Readme from Adam to AdamW, otherwise good to go.
Description
This PR adds an AdamW optimiser to PyBOP. This implementation extends the Pints' Adam class and reimplements it in PyBOP. Adding this upstream to Pints' should also be considered.
This PR should be merged after #255 as it will need to be updated for the new optimiser architecture implemented.
Issue reference
Fixes #295
Review
Before you mark your PR as ready for review, please ensure that you've considered the following:
Type of change
Key checklist:
$ pre-commit run
(or$ nox -s pre-commit
) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)$ nox -s tests
$ nox -s doctest
You can run integration tests, unit tests, and doctests together at once, using
$ nox -s quick
.Further checks:
Thank you for contributing to our project! Your efforts help us to deliver great software.