-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Maximum a Posteriori (MAP) #275
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #275 +/- ##
========================================
Coverage 95.47% 95.48%
========================================
Files 36 36
Lines 2011 2036 +25
========================================
+ Hits 1920 1944 +24
- Misses 91 92 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one comment from my side, thanks @BradyPlanden, nice addition!
Description
This PR adds a MAP cost function with corresponding tests. This cost function has required arguments for the
problem
class as well as thelikelihood
class, this allows the MAP class to be agnostic to the likelihood defined as it constructs the class on initialisation.This PR also updates the codecov job on the
test_on_push
workflow to v4 with additional options.Issue reference
Fixes #248 #277
Review
Before you mark your PR as ready for review, please ensure that you've considered the following:
Type of change
Key checklist:
$ pre-commit run
(or$ nox -s pre-commit
) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)$ nox -s tests
$ nox -s docs
You can run integration tests, unit tests, and doctests together at once, using
$ nox -s quick
.Further checks:
Thank you for contributing to our project! Your efforts help us to deliver great software.