-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix workflow for changing experiment #240
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #240 +/- ##
===========================================
+ Coverage 94.29% 94.30% +0.01%
===========================================
Files 33 33
Lines 1753 1757 +4
===========================================
+ Hits 1653 1657 +4
Misses 100 100 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great — thanks for the fast bugfix @NicolaCourtier! A few small suggestions, happy for you to merge when ready.
Co-authored-by: Brady Planden <[email protected]>
Description
Fix for issue #233. The current function was not being set during the call to
set_params
unlessunmatched_parameters
were present.