Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make likelihoods a type of cost #230

Merged
merged 7 commits into from
Mar 8, 2024

Update _likelihoods.py

a9683f7
Select commit
Loading
Failed to load commit list.
Merged

Make likelihoods a type of cost #230

Update _likelihoods.py
a9683f7
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Mar 8, 2024 in 1s

94.22% (-0.15%) compared to 8d58731

View this Pull Request on Codecov

94.22% (-0.15%) compared to 8d58731

Details

Codecov Report

Attention: Patch coverage is 84.37500% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 94.22%. Comparing base (8d58731) to head (a9683f7).
Report is 11 commits behind head on 210-add-likelihood-classes.

Files Patch % Lines
pybop/costs/base_cost.py 84.61% 2 Missing ⚠️
pybop/costs/fitting_costs.py 0.00% 2 Missing ⚠️
pybop/_optimisation.py 83.33% 1 Missing ⚠️
Additional details and impacted files
@@                      Coverage Diff                       @@
##           210-add-likelihood-classes     #230      +/-   ##
==============================================================
- Coverage                       94.37%   94.22%   -0.15%     
==============================================================
  Files                              33       33              
  Lines                            1760     1750      -10     
==============================================================
- Hits                             1661     1649      -12     
- Misses                             99      101       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.