Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds PR Template #214

Merged
merged 9 commits into from
Mar 6, 2024
Merged

Adds PR Template #214

merged 9 commits into from
Mar 6, 2024

Conversation

BradyPlanden
Copy link
Member

This adds:

  • A PR template
  • Additional nox sessions for easier development
    • run all standard test (unit, integration, examples, notebooks) ->nox -s tests
    • run the doc tests -> nox -s doctest
    • run the above two as one -> nox -s quick
    • run pre-commit -> nox -s pre-commit
  • Bugfix doc builds where path was not set correctly.

This needs to be merged after #139, and closes #185.

@BradyPlanden BradyPlanden linked an issue Feb 22, 2024 that may be closed by this pull request
Copy link

codecov bot commented Feb 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.34%. Comparing base (93f33e6) to head (02ee2e2).
Report is 59 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #214      +/-   ##
===========================================
+ Coverage    94.29%   94.34%   +0.04%     
===========================================
  Files           32       32              
  Lines         1614     1661      +47     
===========================================
+ Hits          1522     1567      +45     
- Misses          92       94       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BradyPlanden BradyPlanden mentioned this pull request Feb 26, 2024
5 tasks
Copy link
Member

@agriyakhetarpal agriyakhetarpal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of these changes look reasonable, thanks, @BradyPlanden!

@BradyPlanden BradyPlanden merged commit 1e6b07d into develop Mar 6, 2024
31 checks passed
@BradyPlanden BradyPlanden deleted the 185-add-pull-request-template branch March 6, 2024 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Pull Request Template
2 participants