-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds Pints' optimisers #117
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #117 +/- ##
===========================================
- Coverage 93.75% 90.57% -3.19%
===========================================
Files 29 18 -11
Lines 993 647 -346
===========================================
- Hits 931 586 -345
+ Misses 62 61 -1 ☔ View full report in Codecov by Sentry. |
… multi-soc from test_spm_optimisers + updt. to SPM
This is now ready for review. In this PR, I've forked one of the example scripts and updated it to include the different optimiser methods we have. We may want to consider moving these to a separate directory, such as Unfortunately, the tests have regressed, but this is to be expected as I have removed the `tests/' directory from the CodeCov bot. The patch percentage is good for the merge, but we will need to add more coverage in the future. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent work on adding the optimisers, thanks @BradyPlanden !
Closes #116. Adds the remaining Pints' optimiser methods, and updates examples.
I've left
_nelder-mead.py
and_cmaes_bare.py
out of this PR, as we have access to the former via SciPy and I don't believe we need two CMAES methods for the latter.