Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PyBaMM version matrix to scheduled tests #123

Closed
BradyPlanden opened this issue Nov 28, 2023 · 3 comments · Fixed by #193
Closed

Add PyBaMM version matrix to scheduled tests #123

BradyPlanden opened this issue Nov 28, 2023 · 3 comments · Fixed by #193
Assignees
Labels
enhancement New feature or request priority:high

Comments

@BradyPlanden
Copy link
Member

Feature description

Add a testing matrix of the most recent pybamm versions to the scheduled daily workflow. The last four releases is probably a good place to start. This should only be added to the most recent python version to avoid clashes.

Motivation

Provides us with a range of supported pybamm versions and should improve ease-of-use for end-users.

Possible implementation

No response

Additional context

No response

@BradyPlanden BradyPlanden added the enhancement New feature or request label Nov 28, 2023
@BradyPlanden BradyPlanden moved this to Todo in v23.12 Nov 28, 2023
@agriyakhetarpal agriyakhetarpal self-assigned this Jan 27, 2024
@agriyakhetarpal
Copy link
Member

Just to clarify – as mentioned in the comment, each PyBaMM version should correspond to a Python version? Or did you mean testing all four PyBaMM versions with the latest Python version?

This should be doable by checking out the PyBaMM repository from a particular tag and building it from source. The PyPI wheels corresponding to a version can be used directly too, as long as we have support for required platforms and architectures (should be all except M-series macOS).

@BradyPlanden
Copy link
Member Author

Hi Agriya,

Good question, I hadn't fleshed out the concept much in the original post. The goal is to ensure that a list of recent pybamm versions is supported within pybop. Ideally this would allow us to relax the pybamm version constraint and/or have a metric to decide when to bump the dependency.

Creating an implementation for the latest Python and building from source (or wheels, if applicable) sounds like a good compromise between test time and coverage. That said, I'm not opposed to testing against the Python matrix we currently have in the scheduled tests.

@agriyakhetarpal
Copy link
Member

Testing against the Python matrix, even though it would consume a lot of parallel jobs (four PyBaMM versions per Python version), sounds like the best way to go forward with.

We can do both things: use the wheels for now while building from source for M-series. We may switch to using the wheels for everything when I finish pybamm-team/PyBaMM#3772.

agriyakhetarpal added a commit to agriyakhetarpal/PyBOP that referenced this issue Feb 11, 2024
agriyakhetarpal added a commit to agriyakhetarpal/PyBOP that referenced this issue Feb 11, 2024
agriyakhetarpal added a commit to agriyakhetarpal/PyBOP that referenced this issue Feb 11, 2024
agriyakhetarpal added a commit to agriyakhetarpal/PyBOP that referenced this issue Feb 11, 2024
agriyakhetarpal added a commit to agriyakhetarpal/PyBOP that referenced this issue Feb 11, 2024
agriyakhetarpal added a commit to agriyakhetarpal/PyBOP that referenced this issue Feb 11, 2024
agriyakhetarpal added a commit to agriyakhetarpal/PyBOP that referenced this issue Feb 11, 2024
agriyakhetarpal added a commit to agriyakhetarpal/PyBOP that referenced this issue Feb 11, 2024
agriyakhetarpal added a commit to agriyakhetarpal/PyBOP that referenced this issue Feb 11, 2024
agriyakhetarpal added a commit to agriyakhetarpal/PyBOP that referenced this issue Feb 11, 2024
agriyakhetarpal added a commit to agriyakhetarpal/PyBOP that referenced this issue Feb 11, 2024
agriyakhetarpal added a commit to agriyakhetarpal/PyBOP that referenced this issue Feb 11, 2024
agriyakhetarpal added a commit to agriyakhetarpal/PyBOP that referenced this issue Feb 11, 2024
agriyakhetarpal added a commit to agriyakhetarpal/PyBOP that referenced this issue Feb 11, 2024
agriyakhetarpal added a commit to agriyakhetarpal/PyBOP that referenced this issue Feb 11, 2024
agriyakhetarpal added a commit to agriyakhetarpal/PyBOP that referenced this issue Feb 12, 2024
agriyakhetarpal added a commit to agriyakhetarpal/PyBOP that referenced this issue Feb 12, 2024
agriyakhetarpal added a commit to agriyakhetarpal/PyBOP that referenced this issue Feb 12, 2024
agriyakhetarpal added a commit to agriyakhetarpal/PyBOP that referenced this issue Feb 13, 2024
agriyakhetarpal added a commit to agriyakhetarpal/PyBOP that referenced this issue Feb 13, 2024
agriyakhetarpal added a commit to agriyakhetarpal/PyBOP that referenced this issue Feb 14, 2024
Coverage is already up for this, this is just for PyBaMM 23.5
agriyakhetarpal added a commit to agriyakhetarpal/PyBOP that referenced this issue Feb 14, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in v23.12 Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request priority:high
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants