-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pcc02 #657
Pcc02 #657
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- You need to pull-request one challenge at a time. I.e. create 2 separated requests for 1st and 2nd challenges.
- Do not change additional files, like readme's and tests and do not commit these files.
I know, but there were 2 minor commits in my repository from challenge 1 which entered the history
I just removed the additional file in a new commit. I tried to revert the commit without success, just kept getting conflicts. I don't know if this fixes it or which other additional action I have to take. |
I undid the changes made in the previous commits with the recent one. What I need to do further? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry that it took so long.
Difficulty level (1-10): [7]
Estimated time spent (hours): [8]
Completed (yes/no): [Yes]
I stretched my coding skills (if yes what did you learn?): Efficient iteration with the itertools and filter function.
Other feedback (what can we improve?): It's was not clear we must check for all permutations (NUM_LETTERS...1) to find the optimal word. I initially understood it was only NUM_LETTERS permutations, which is not the same.