Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pcc02 #657

Merged
merged 7 commits into from
Nov 7, 2019
Merged

Pcc02 #657

merged 7 commits into from
Nov 7, 2019

Conversation

ronaldokun
Copy link
Contributor

Difficulty level (1-10): [7]
Estimated time spent (hours): [8]
Completed (yes/no): [Yes]
I stretched my coding skills (if yes what did you learn?): Efficient iteration with the itertools and filter function.
Other feedback (what can we improve?): It's was not clear we must check for all permutations (NUM_LETTERS...1) to find the optimal word. I initially understood it was only NUM_LETTERS permutations, which is not the same.

Copy link
Collaborator

@schattencheg schattencheg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. You need to pull-request one challenge at a time. I.e. create 2 separated requests for 1st and 2nd challenges.
  2. Do not change additional files, like readme's and tests and do not commit these files.

@ronaldokun
Copy link
Contributor Author

1. You need to pull-request one challenge at a time. I.e. create 2 separated requests for 1st and 2nd challenges.

I know, but there were 2 minor commits in my repository from challenge 1 which entered the history

2. Do not change additional files, like readme's and tests and do not commit these files.

I just removed the additional file in a new commit. I tried to revert the commit without success, just kept getting conflicts.

I don't know if this fixes it or which other additional action I have to take.

@ronaldokun
Copy link
Contributor Author

I undid the changes made in the previous commits with the recent one. What I need to do further?

Copy link
Collaborator

@schattencheg schattencheg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry that it took so long.

@schattencheg schattencheg merged commit 51f88c6 into pybites:community Nov 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants