PCC04 jatinsinghal1921 #529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feoh
reviewed
Aug 27, 2019
| @@ -0,0 +1,6 @@ | |||
| # Don't track content of these folders | |||
There was a problem hiding this comment.
May wish to eliminate .gitignore from your PR. The contents you add are Windows specific, and it's best practice to let everyone define their own local ignore settings.
feoh
approved these changes
Sep 6, 2019
| if not os.path.exists(DEST_DIR): | ||
| os.makedirs(DEST_DIR) | ||
|
|
||
| file_name = "./" + DEST_DIR + "/" + self.handle + ".csv" |
There was a problem hiding this comment.
Might consider using pathlib for this. Cross platform and much cleaner.
|
|
||
| def __getitem__(self, pos): | ||
| """See http://pybit.es/python-data-model.html""" | ||
| return (self._tweets)[pos] |
There was a problem hiding this comment.
Consider adding some type checks? As per https://docs.python.org/3/reference/datamodel.html#object.__getitem__ you can throw a TypeError here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Difficulty level (1-10): [2]
Estimated time spent (hours): [4]
Completed (yes/no): [Yes]
I stretched my coding skills (if yes what did you learn?): [I learned Tweepy API modules.]
Other feedback (what can we improve?): []