MinGW support #36
MinGW support #36
Conversation
On windows the temp file cannot be opened a second time while it is still opened by python. Close the file in python before asking the compiler to read it. See https://docs.python.org/3.7/library/tempfile.html#tempfile.NamedTemporaryFile
| try: | ||
| compiler.compile([fname], extra_postargs=[flagname]) | ||
| except setuptools.distutils.errors.CompileError: | ||
| return False |
There was a problem hiding this comment.
What is the reason for not deleting the temporary file and moving this out of the context manager?
There was a problem hiding this comment.
On windows the temp file cannot be opened a second time while
it is still opened by python. Close the file in python before
asking the compiler to read it.
See https://docs.python.org/3.7/library/tempfile.html#tempfile.NamedTemporaryFile
There was a problem hiding this comment.
But in this case, the file should be deleted later.
There was a problem hiding this comment.
How about something like below, so that I don't have to worry about cleaning up stuff?
import tempfile, os
with tempfile.TemporaryDirectory() as d:
fname = os.path.join(d, 'main.cpp')
with open(fname, 'w') as f:
f.write('int main (int argc, char **argv) { return 0; }')
try:
compiler.compile([fname], extra_postargs=[flagname])
except setuptools.distutils.errors.CompileError:
return False
return TrueThere was a problem hiding this comment.
TemporaryDirectory is not in py 2.7. Reverting to deleting the file
|
Has anyone tried to build this in MinGW? I see the Appveyor VMs use MSVC and conda ... |
|
Just to let you guys know that on my mingw system the pybind11 minimal example compiles fine without this PR. |
Yes, but does it work with MinGW 5.x or 4.x series which defaults to C++98? |
|
@SylvainCorlay, can you review again? |
This reverts commit 6be7a0c.
|
This looks good to me. The build failures seem unrelated. |
|
Ping |
wjakob
force-pushed
the
master
branch
2 times, most recently
from
fe696bc to
08a2f37
Compare
|
This is ready for review now. |
|
Rebased and merged in 187e874, can you double-check that it's okay? |
No description provided.