-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[smart_holder] Bake smart_holder functionality into class_
and type_caster_base
#5257
Commits on Jul 21, 2024
-
Put bakein branch @ 18b72c0 on top of smart_holder branch:
Commands used: ``` git checkout bakein git diff smart_holder > ~/zd git checkout smart_holder git checkout -b bakein_sh patch -p 1 < ~/zd git checkout smart_holder \ MANIFEST.in \ README.rst \ README_smart_holder.rst \ docs/advanced/smart_ptrs.rst \ ubench/holder_comparison.cpp \ ubench/holder_comparison.py \ ubench/holder_comparison_extract_sheet_data.py \ ubench/number_bucket.h \ ubench/python/number_bucket.clif git add -A ```
Ralf W. Grosse-Kunstleve committedJul 21, 2024 Configuration menu - View commit details
-
Copy full SHA for 82c9ce7 - Browse repository at this point
Copy the full SHA 82c9ce7View commit details -
Add back README_smart_holder.rst in tests/extra_python_package/test_f…
…iles.py
Ralf W. Grosse-Kunstleve committedJul 21, 2024 Configuration menu - View commit details
-
Copy full SHA for fbd1295 - Browse repository at this point
Copy the full SHA fbd1295View commit details
Commits on Jul 22, 2024
-
Merge branch 'smart_holder' into bakein_sh
Ralf W. Grosse-Kunstleve committedJul 22, 2024 Configuration menu - View commit details
-
Copy full SHA for 58f9e18 - Browse repository at this point
Copy the full SHA 58f9e18View commit details
Commits on Jul 23, 2024
-
Restore smart_holder_poc.h as-is on smart_holder branch (i.e. undo `P…
…YBIND11_SMART_HOLDER_PADDING`, which was meant for stress-testing only).
Ralf W. Grosse-Kunstleve committedJul 23, 2024 Configuration menu - View commit details
-
Copy full SHA for c02d2cd - Browse repository at this point
Copy the full SHA c02d2cdView commit details
Commits on Jul 26, 2024
-
Insert
std::move()
as suggested by @laramielRalf W. Grosse-Kunstleve committedJul 26, 2024 Configuration menu - View commit details
-
Copy full SHA for 99b6572 - Browse repository at this point
Copy the full SHA 99b6572View commit details -
property_cpp_function_sh_*
named specializations, as suggested by @…Ralf W. Grosse-Kunstleve committedJul 26, 2024 Configuration menu - View commit details
-
Copy full SHA for 16cf7ad - Browse repository at this point
Copy the full SHA 16cf7adView commit details -
Call
property_cpp_function_classic
member functions, rather than in……lining the implementations.
Ralf W. Grosse-Kunstleve committedJul 26, 2024 Configuration menu - View commit details
-
Copy full SHA for 0bcfbd4 - Browse repository at this point
Copy the full SHA 0bcfbd4View commit details -
Use
PYBIND11_HAVE_INTERNALS_WITH_SMART_HOLDER_SUPPORT
in holder_com……parison.cpp (holder_comparison.py is NOT changed accordingly in this commit, i.e. can still only be run if the smart_holder functionality is available).
Ralf W. Grosse-Kunstleve committedJul 26, 2024 Configuration menu - View commit details
-
Copy full SHA for 2644d6e - Browse repository at this point
Copy the full SHA 2644d6eView commit details -
Systematically rename
loaded_as
toload_as
(shared_ptr
, `unique……_ptr`) as suggested by @laramiel
Ralf W. Grosse-Kunstleve committedJul 26, 2024 Configuration menu - View commit details
-
Copy full SHA for 336860d - Browse repository at this point
Copy the full SHA 336860dView commit details -
Make change as suggested by @laramiel. This makes it much more obviou…
…s that the latest implementation of `smart_holder_from_unique_ptr()` accepts all existing `return_value_policy` enum values except `copy`.
Ralf W. Grosse-Kunstleve committedJul 26, 2024 Configuration menu - View commit details
-
Copy full SHA for cb6a85f - Browse repository at this point
Copy the full SHA cb6a85fView commit details
Commits on Jul 27, 2024
-
Resolve
BAKEIN_WIP: Rewrite comment.
forproperty_cpp_function_*
……specializations.
Ralf W. Grosse-Kunstleve committedJul 27, 2024 Configuration menu - View commit details
-
Copy full SHA for 0316f74 - Browse repository at this point
Copy the full SHA 0316f74View commit details -
Resolve `BAKEIN_WIP: Add comment to explain: This is meant for stress…
…-testing only.`
Ralf W. Grosse-Kunstleve committedJul 27, 2024 Configuration menu - View commit details
-
Copy full SHA for 053467f - Browse repository at this point
Copy the full SHA 053467fView commit details -
Resolve all remaining BAKEIN_WIP (in pybind11/cast.h).
Leave only two pairs of SMART_HOLDER_BAKEIN_FOLLOW_ON comments: refactoring of copyable_holder_caster, move_only_holder_caster. This is best left until after the smart_holder branch is merged into the master branch.
Ralf W. Grosse-Kunstleve committedJul 27, 2024 Configuration menu - View commit details
-
Copy full SHA for 523eafa - Browse repository at this point
Copy the full SHA 523eafaView commit details -
Remove obsolete
using holder_type = smart_holder;
inload_helper
Ralf W. Grosse-Kunstleve committedJul 27, 2024 Configuration menu - View commit details
-
Copy full SHA for 7c0aed7 - Browse repository at this point
Copy the full SHA 7c0aed7View commit details -
Add SMART_HOLDER_BAKEIN_FOLLOW_ON comment for `internals::default_hol…
…der`
Ralf W. Grosse-Kunstleve committedJul 27, 2024 Configuration menu - View commit details
-
Copy full SHA for 0ca3ca7 - Browse repository at this point
Copy the full SHA 0ca3ca7View commit details -
README_smart_holder.rst update (line count reduced from 356 to 123).
Ralf W. Grosse-Kunstleve committedJul 27, 2024 Configuration menu - View commit details
-
Copy full SHA for 4a7f895 - Browse repository at this point
Copy the full SHA 4a7f895View commit details
Commits on Jul 29, 2024
-
Merge branch 'sh_merge_master' into bakein_sh_merge_ahead
Ralf W. Grosse-Kunstleve committedJul 29, 2024 Configuration menu - View commit details
-
Copy full SHA for 67ac541 - Browse repository at this point
Copy the full SHA 67ac541View commit details
Commits on Jul 30, 2024
-
Merge branch 'sh_merge_master' into bakein_sh
Ralf W. Grosse-Kunstleve committedJul 30, 2024 Configuration menu - View commit details
-
Copy full SHA for 8ffe837 - Browse repository at this point
Copy the full SHA 8ffe837View commit details
Commits on Jul 31, 2024
-
Merge branch 'smart_holder' into bakein_sh
Ralf W. Grosse-Kunstleve committedJul 31, 2024 Configuration menu - View commit details
-
Copy full SHA for 2e9769a - Browse repository at this point
Copy the full SHA 2e9769aView commit details