Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: skipping test for Windows Clang failure #5062

Merged
merged 8 commits into from
Mar 21, 2024
Merged

ci: skipping test for Windows Clang failure #5062

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
41b2295
ci: trying things for Windows Clang failure
henryiii Mar 20, 2024
161718b
WIP: try using older clang
henryiii Mar 20, 2024
3d81045
tests: skip broken test
henryiii Mar 20, 2024
8e4348a
tests: try to skip test in tests
henryiii Mar 20, 2024
6daeb9c
fix(tests): Prefer __version__ over MSVC
henryiii Mar 20, 2024
209083c
chore: avoid warning on Clang
henryiii Mar 20, 2024
a65c308
Update tests/test_exceptions.py
henryiii Mar 21, 2024
4ac43f6
Update tests/test_exceptions.py
henryiii Mar 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1089,6 +1089,7 @@ jobs:
-DDOWNLOAD_EIGEN=ON
-DCMAKE_CXX_COMPILER=clang++
-DCMAKE_CXX_STANDARD=17
-DPYBIND11_PYTEST_ARGS='-k "not test_throw_nested_exception"'
henryiii marked this conversation as resolved.
Show resolved Hide resolved

- name: Build
run: cmake --build . -j 2
Expand Down
6 changes: 5 additions & 1 deletion tests/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -520,11 +520,15 @@ set(PYBIND11_TEST_PREFIX_COMMAND
""
CACHE STRING "Put this before pytest, use for checkers and such")

set(PYBIND11_PYTEST_ARGS
""
CACHE STRING "Extra arguments for pytest")

# A single command to compile and run the tests
add_custom_target(
pytest
COMMAND ${PYBIND11_TEST_PREFIX_COMMAND} ${PYTHON_EXECUTABLE} -m pytest
${PYBIND11_ABS_PYTEST_FILES}
${PYBIND11_ABS_PYTEST_FILES} ${PYBIND11_PYTEST_ARGS}
DEPENDS ${test_targets}
WORKING_DIRECTORY "${CMAKE_CURRENT_BINARY_DIR}"
USES_TERMINAL)
Expand Down
Loading