Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add missing spaces to error string #4906

Merged
merged 2 commits into from
Oct 27, 2023
Merged

Conversation

chunyang
Copy link
Contributor

Description

Add missing spaces to error message and always end with a newline.

- If you are convinced there is no bug in your code, you can #define PYBIND11_NO_ASSERT_GIL_HELD_INCREF_DECREFto disable this check. In that case you have to ensure this #define is consistently used for all translation units linked into a given pybind11 extension, otherwise there will be ODR violations.The failing pybind11::handle::inc_ref() call was triggered on a bool object.
+ If you are convinced there is no bug in your code, you can #define PYBIND11_NO_ASSERT_GIL_HELD_INCREF_DECREF to disable this check. In that case you have to ensure this #define is consistently used for all translation units linked into a given pybind11 extension, otherwise there will be ODR violations. The failing pybind11::handle::inc_ref() call was triggered on a bool object.

@rwgk
Copy link
Collaborator

rwgk commented Oct 27, 2023

Thanks!

@rwgk rwgk merged commit 1e28599 into pybind:master Oct 27, 2023
81 checks passed
@github-actions github-actions bot added the needs changelog Possibly needs a changelog entry label Oct 27, 2023
@rwgk rwgk removed the needs changelog Possibly needs a changelog entry label Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants