Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 3.12b2 testing #4695

Merged
merged 2 commits into from
Jun 10, 2023
Merged

Python 3.12b2 testing #4695

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d23f1b6
Uncomment `Interface test` sections (test_embed)
Jun 10, 2023
d292af8
fix: setuptools has been removed from default installs in 3.12
henryiii Jun 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,7 +180,9 @@ jobs:
# This makes sure the setup_helpers module can build packages using
# setuptools
- name: Setuptools helpers test
run: pytest tests/extra_setuptools
run: |
pip install setuptools
pytest tests/extra_setuptools
if: "!(matrix.runs-on == 'windows-2022')"


Expand Down Expand Up @@ -242,8 +244,6 @@ jobs:
python -m pip install -r tests/requirements.txt

- name: Configure
env:
SETUPTOOLS_USE_DISTUTILS: stdlib
Comment on lines -245 to -246
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing this - this is invalid in 3.12, there is no stdlib distutils, and we shouldn't be using before that either. Just looking to see what fails.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI, I expect this was to build numpy before wheels were available.

run: >
cmake -S . -B build
-DCMAKE_BUILD_TYPE=Debug
Expand Down
19 changes: 10 additions & 9 deletions .github/workflows/upstream.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@

name: Upstream

on:
Expand Down Expand Up @@ -65,8 +64,8 @@ jobs:
- name: Python tests C++11
run: cmake --build build11 --target pytest -j 2

# - name: C++11 tests
# run: cmake --build build11 --target cpptest -j 2
- name: C++11 tests
run: cmake --build build11 --target cpptest -j 2

- name: Interface test C++11
run: cmake --build build11 --target test_cmake_build
Expand All @@ -80,14 +79,14 @@ jobs:
-DDOWNLOAD_EIGEN=ON
-DCMAKE_CXX_STANDARD=17

- name: Build
- name: Build C++17
run: cmake --build build17 -j 2

- name: Python tests
- name: Python tests C++17
run: cmake --build build17 --target pytest

# - name: C++ tests
# run: cmake --build build17 --target cpptest
- name: C++17 tests
run: cmake --build build17 --target cpptest

# Third build - C++17 mode with unstable ABI
- name: Configure (unstable ABI)
Expand All @@ -105,10 +104,12 @@ jobs:
- name: Python tests (unstable ABI)
run: cmake --build build17max --target pytest

- name: Interface test
- name: Interface test (unstable ABI)
run: cmake --build build17max --target test_cmake_build

# This makes sure the setup_helpers module can build packages using
# setuptools
- name: Setuptools helpers test
run: pytest tests/extra_setuptools
run: |
pip install setuptools
pytest tests/extra_setuptools